-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Unable to edit a 'direct' room setting in the admin due to the room name #21636
[FIX] Unable to edit a 'direct' room setting in the admin due to the room name #21636
Conversation
updating the code
updating the code
updating the fork
update main branch
updating the branch
Update fork
Upating the fork
Updating fork
Updating fork
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO a proper fix for this issue would be changing the frontend to actually not send the room name on payload since that was not changed (the field is event disabled). if the name is sent on the payload, the backend should validate it, otherwise let's say someone uses the endpoint providing only the room name, the endpoint will return success but nothing will be done, which I'd consider a bug.
@sampaiodiego alright, i will do the changes ASAP 👍 |
Proof that it works: 2021-04-29.01-51-17.mp4 |
…autolinker-phone * 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] Unable to edit a 'direct' room setting in the admin due to the room name (#21636)
…t.Chat (#41) * Bump version to 3.14.0-rc.0 * Regression: Fix services Docker image build (RocketChat#21750) * Regression: Fix room not returning to the previous room after directory (RocketChat#21757) * Regression: Bold, italic and strike render (Original markdown) (RocketChat#21747) * [FIX] Toolbox icons order (RocketChat#21739) * Regression: Fix scroll to bottom (RocketChat#21731) * Regression: Reconnection not working properly due to changes on ECHD Proxy (RocketChat#21741) * [FIX] Discussions not showing in Safari (RocketChat#21270) Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz> * Regression: Change CI files hashes for caching (RocketChat#21776) * regression: Markdown broken on safari (RocketChat#21780) Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> * [FIX] Too many request on loadHistory method (RocketChat#21594) Co-authored-by: Diego Sampaio <chinello@gmail.com> Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz> Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> * Regression: Update fuselage for icons fix (RocketChat#21809) * Bump version to 3.14.0-rc.1 * Fix attachment previews. (RocketChat#21746) * Regression: Unread Threads Header and List (RocketChat#21816) * regression: Italic being parsed with surrounding non-whitespace text (RocketChat#21815) Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> * Regression: team sync not accepting multiple teams (RocketChat#21768) * Chore: Cache EE node_modules on CI (RocketChat#21831) * QoL improvements to add channel to team flow (RocketChat#21778) * Chore: Add tests for teams.update REST endpoint (RocketChat#21653) * Regression: Problem with Importer's logs (RocketChat#21812) * Fix node_modules cache path * [FIX] Omnichannel Activity Monitor closing chats returned to the queue (RocketChat#21782) * Fix VisitorInactivityMonitor is still monitoring rooms that returned to Queue Chats * Apply suggestions from code review * Fix condition. Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com> * Bump version to 3.14.0-rc.2 * Regression: Reactivate direct conversations only if all involved users are active (RocketChat#21714) * Fix node_modules cache path again * [FIX][Enterprise] Omnichannel simultaneous chat limit is not properly checking the limit by department (RocketChat#21839) * Bump Apps-Engine version (RocketChat#21840) * Bump version to 3.14.0-rc.3 * [FIX] Duplicated header on admin's user contextualbar (RocketChat#21810) Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com> * bump fuselage (RocketChat#21841) * Bump version to 3.14.0-rc.4 * Bump version to 3.14.0 * Bump version to 3.15.0-develop * Chore: Correct some spelling/typos in English for descriptions/modal (RocketChat#21832) * Chore: fix invalid type name on TS file (RocketChat#21814) * Chore: Add missing 'Teams' label in the i18n files for every languages (RocketChat#21751) * i18n: Correct a typo in German (RocketChat#21711) * Chore: Add mongo 4.2 to array of mongo versions supported (RocketChat#21550) * Language update from LingoHub 🤖 on 2021-04-26Z (RocketChat#21801) * Language update from LingoHub 🤖 Project Name: Rocket.Chat Project Link: https://translate.lingohub.com/rocketchat/dashboard/rocket-dot-chat User: Robot LingoHub Easy language translations with LingoHub 🚀 * fix number Co-authored-by: Robot LingoHub <robot@lingohub.com> Co-authored-by: Diego Sampaio <chinello@gmail.com> * [FIX] Unable to edit a 'direct' room setting in the admin due to the room name (RocketChat#21636) * [FIX][APPS] Scheduler duplicating recurrent tasks after server restart (RocketChat#21866) Co-authored-by: Douglas Gubert <douglas.gubert@gmail.com> * Chore: Doc Client Readme (RocketChat#21588) * [FIX] Custom OAuth not being completely deleted (RocketChat#21637) * Upgrade to GitHub-native Dependabot (RocketChat#21874) * Upgrade to GitHub-native Dependabot * Add GitHub Action and EE NPM * Remove old ignored package versions Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Diego Sampaio <chinello@gmail.com> * Bump actions/stale from v3.0.8 to v3.0.18 (RocketChat#21877) Bumps [actions/stale](https://github.com/actions/stale) from v3.0.8 to v3.0.18. - [Release notes](https://github.com/actions/stale/releases) - [Commits](actions/stale@v3.0.8...3b3c3f0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [FIX] User Impersonation through sendMessage API (RocketChat#20391) Co-authored-by: Diego Sampaio <chinello@gmail.com> * [FIX] Make the FR translation consistent with the 'room' translation + typos (RocketChat#21913) * Language update from LingoHub 🤖 (RocketChat#21917) Project Name: Rocket.Chat Project Link: https://translate.lingohub.com/rocketchat/dashboard/rocket-dot-chat User: Robot LingoHub Easy language translations with LingoHub 🚀 Co-authored-by: Robot LingoHub <robot@lingohub.com> * [IMPROVE] Omnichannel Room Information panel flow when user save or close on form page. (RocketChat#21688) * back contextualbar chat room form * fix back action and close Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com> Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat> * [FIX] When closing chats a comment is always required (RocketChat#21947) * [NEW][APPS] Ability for Rocket.Chat Apps to delete rooms (RocketChat#21875) * add bridge method to delete rooms * fix no-trailling-spaces Co-authored-by: Thassio Victor <tvmcarvalho@gmail.com> * Regression: Fix new 'message-impersonate' permission blocking livechat messages (RocketChat#21961) * [NEW] Option to prevent users from using Invisible status (RocketChat#20084) Co-authored-by: Diego Sampaio <chinello@gmail.com> * [FIX] Uploading files from WebDAV (RocketChat#21948) * [FIX] Handle NPS errors instead of throwing them (RocketChat#21945) * [NEW] Option to notify failed login attempts to a channel (RocketChat#21968) * Regression: Fix send message validation (RocketChat#21982) * [FIX] No warning message is sent when user is removed from a team's main channel (RocketChat#21949) * [NEW] New Message Parser (RocketChat#21962) * String helpers (RocketChat#21988) * [FIX] iFrame size on embedded videos (RocketChat#21992) * [FIX] Header Tag Visual Issues (RocketChat#21991) * [FIX] Maximum 25 channels can be loaded in the teams' channels list (RocketChat#21708) * [FIX] Correcting a the wrong Archived label in edit room (RocketChat#21717) * [FIX] Auto-join Tags misalignment (RocketChat#21980) * [FIX] errors when viewing a room that you're not subscribed to (RocketChat#21984) * [FIX] Error when you look at the members list of a room in which you are not a member (RocketChat#21952) * [FIX] Label's disabled color on Create New Modal (RocketChat#21975) * [FIX] Convert a channel to Team Modal Visual Issues (RocketChat#21967) * [FIX] Missing margins on select team modal (RocketChat#21965) * [FIX] Redirect on remove user from channel by user profile tab (RocketChat#21951) * [FIX] Wrong color and size, thread list Metrics (RocketChat#21950) * [FIX] Visibility of burger menu on certain width (RocketChat#20736) Co-authored-by: dougfabris <deefabris@gmail.com> * Language update from LingoHub 🤖 (RocketChat#21998) Project Name: Rocket.Chat Project Link: https://translate.lingohub.com/rocketchat/dashboard/rocket-dot-chat User: Robot LingoHub Easy language translations with LingoHub 🚀 Co-authored-by: Robot LingoHub <robot@lingohub.com> * Chore: Storybook organization and errors (RocketChat#21923) * [NEW] Back button for Omnichannel (RocketChat#21647) Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz> * [FIX] Unable to get channels, sort by most recent message (RocketChat#21701) * [FIX] Fixed the fact that when a team was deleted, not all channels were unlinked from the team (RocketChat#21942) * [FIX] Tooltip pointer is blocking Text (RocketChat#21645) * [FIX] IE11 support (RocketChat#21893) Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz> * [FIX] Workaround for Autolinker phone problem (RocketChat#21515) Co-authored-by: Gabriel Henriques <gabriel.henriques@rocket.chat> * [IMPROVE] Prevent gallery to close when clicking on a non-zoomable image (RocketChat#21854) * Add two more test cases to the slash-command test suite (RocketChat#21317) Co-authored-by: Kevin Aleman <kevin.aleman@rocket.chat> * [FIX] Horizontal scrollbar not showing on tables (RocketChat#21852) * [FIX] Adding retentionEnabledDefault check before showing warning message (RocketChat#20692) Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat> * [FIX] Adding Custom Fields to show on user info check (RocketChat#20955) * [FIXf] Parent Room Tag Overlapping (RocketChat#22009) * [FIX] Missing proper permissions on Teams Channels (RocketChat#21946) * [IMPROVE] Replace method to API Endpoint on Prune Messages (RocketChat#21836) * [FIX] Unable to update app manually (RocketChat#21215) Co-authored-by: Douglas Gubert <d-gubert@users.noreply.github.com> * [FIX] Adding permission 'add-team-channel' for Team Channels Contextual bar (RocketChat#21591) * [FIX] Dismiss button for save your encryption password dialog Issue#13557 (RocketChat#19872) Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat> * [FIX] Close stream properly at Omnichannel room when move to queue (RocketChat#22015) Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz> * [FIX] Wrong icon on "Move to team" option in the channel info actions (RocketChat#21944) Co-authored-by: dougfabris <deefabris@gmail.com> * regression: UserInfoTab Broken (RocketChat#22019) * Regression: Add impersonate permission to app role (RocketChat#22006) * [IMPROVE] Add support to queries in `channels.members` and `groups.members` endpoints (RocketChat#21414) Co-authored-by: Diego Sampaio <chinello@gmail.com> * [IMPROVE] Add support to queries in the `im.members` endpoint (RocketChat#21471) Co-authored-by: Diego Sampaio <chinello@gmail.com> * [FIX] Removed fields from User Info for which the user doesn't have permissions. (RocketChat#20923) Co-authored-by: dougfabris <deefabris@gmail.com> * [FIX] Unpin message reactivity (RocketChat#22029) * [FIX] Scenarios where 2FA enforcement was not working properly (RocketChat#22017) * [FIX] Contact Bar not reactive (RocketChat#22016) * WIP * Bump * ContactContetualBar -> TS * Opss * méeeee * done * fix * ?? * TS fix * remove tabId from quickactions component * Fix onhold missing * prevent error with no contact * prepare directory chatinfo to use the the endpoint instead the hook useOmnichannelRoom * Canelada * fix identation * fix stream issues * fix resume chat onhold * remove unnecessary import * missed fields chat info panel * ChatsContextualBar reactive * Allow agents to edit rooms on contact center. Co-authored-by: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat> Co-authored-by: Rafael <rafaelblink@gmail.com> Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com> * regression: Select Team Modal margin (RocketChat#22030) * regression: Fix Users list in the Administration (RocketChat#22034) * Update permissions.js (RocketChat#22048) * [FIX] Notify with sound first message in queue list (RocketChat#21969) * notify with sound queue chat * fix typo and remove comments * use added event * Change audio check Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com> Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com> * [EE] Improve Forwarding Department behaviour with Waiting queue feature (RocketChat#22043) * [EE] Fix Forwarding Department not working with Waiting queue feature * add waiting queue feature enabled check * Refactor * Fix forwarding of agents not working * Apply suggestions from code review Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com> * Handle transfer api response properly on client + refactor * Avoid passing unnecessary params * Remove throw error. * Improve throw message logic. * Fix on-hold queue. Methods have been removed in another PR. * Remove all subscription from a chat placed on-hold. Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com> * [NEW] Paginated and Filtered selects on new/edit unit (RocketChat#22052) * create endpoint to show departments not related with unit * department refactor endpoint by unit and available by unit * [NEW] Paginated and Filtered selects on new/edit unit * TS fixes Typescript pls don't hurt me * More TS fixes Co-authored-by: Rafael <rafaelblink@gmail.com> * regression: fix departments with empty ancestors not being returned (RocketChat#22068) * Regression: fix departments with empty ancestors not being returned * fix not being able to select the same thing again * regression: bump Rocket.Chat.Fuselage package with paginated selects (RocketChat#22059) Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz> * Regression: Match `name` or `fname` when fetching room to send notification for blocked log in attemps (RocketChat#22067) * [IMPROVE] Omnichannel Room Information panel flow when user save or close on form page. (RocketChat#21688) * back contextualbar chat room form * fix back action and close Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com> Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat> * [FIX] When closing chats a comment is always required (RocketChat#21947) * [FIX] IE11 support (RocketChat#21893) Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz> * [FIX] Close stream properly at Omnichannel room when move to queue (RocketChat#22015) Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz> * Update permissions.js (RocketChat#22048) * [FIX] Notify with sound first message in queue list (RocketChat#21969) * notify with sound queue chat * fix typo and remove comments * use added event * Change audio check Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com> Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com> * [NEW] Paginated and Filtered selects on new/edit unit (RocketChat#22052) * create endpoint to show departments not related with unit * department refactor endpoint by unit and available by unit * [NEW] Paginated and Filtered selects on new/edit unit * TS fixes Typescript pls don't hurt me * More TS fixes Co-authored-by: Rafael <rafaelblink@gmail.com> * regression: fix departments with empty ancestors not being returned (RocketChat#22068) * Regression: fix departments with empty ancestors not being returned * fix not being able to select the same thing again * [Patch] [EE] Improve Forwarding Department behaviour with Waiting queue feature (RocketChat#22077) * [EE] Fix Forwarding Department not working with Waiting queue feature (cherry picked from commit 2b50040) * add waiting queue feature enabled check (cherry picked from commit d9fe3e3) * Refactor (cherry picked from commit 1b5c973) * Fix forwarding of agents not working (cherry picked from commit b4b3c3d) * Apply suggestions from code review Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com> (cherry picked from commit 0c6f7ec) * Handle transfer api response properly on client + refactor (cherry picked from commit d750c59) * Avoid passing unnecessary params (cherry picked from commit 53eec95) * Remove throw error. (cherry picked from commit deccab9) * Improve throw message logic. (cherry picked from commit 85b015d) * Fix conflicts * Remove all subscription from a chat placed on-hold. (cherry picked from commit d49c8fe) * up fuselage version * add string-helpers package * [EE] Improve Forwarding Department behaviour with Waiting queue feature (RocketChat#22043) * [EE] Fix Forwarding Department not working with Waiting queue feature * add waiting queue feature enabled check * Refactor * Fix forwarding of agents not working * Apply suggestions from code review Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com> * Handle transfer api response properly on client + refactor * Avoid passing unnecessary params * Remove throw error. * Improve throw message logic. * Fix on-hold queue. Methods have been removed in another PR. * Remove all subscription from a chat placed on-hold. Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com> Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com> Co-authored-by: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat> * Bump version to 3.14.1 * [FIX] Permission's scope on Teams Channels (RocketChat#22083) * Chore: Update Docker container references to use registry.rocket.chat endpoint (RocketChat#22080) * [FIX] Incorrect error message when opening channel in anonymous read (RocketChat#22066) * [FIX] Incorrect Team's Info spacing (RocketChat#22021) * [FIX] Remove referer header when requesting attachment data (RocketChat#21987) * [FIX] App crashes when downloads come from WebDAV and the server is not available (RocketChat#21985) * [FIX] Display Modes (RocketChat#22058) Co-authored-by: dougfabris <deefabris@gmail.com> * Add new EE routing system algorithm for Omnichannel. (RocketChat#22090) Co-authored-by: Rafael Ferreira <rafaelblink@gmail.com> * regression: Misspelled property in migration 225 (RocketChat#22093) * [IMPROVE] Support for Google OAuth for mobile app (RocketChat#22014) * [IMPROVE] Add groups to the directory channels list (RocketChat#21687) Co-authored-by: Diego Sampaio <chinello@gmail.com> * Language update from LingoHub 🤖 on 2021-05-18Z (RocketChat#22065) Co-authored-by: Rodrigo Nascimento <rodrigoknascimento@gmail.com> Co-authored-by: Diego Sampaio <chinello@gmail.com> * [FIX] Prune messages not cleaning up unread threads (RocketChat#21326) * i18n: Add missing translation string in account preference (RocketChat#21448) * [FIX] Unable to edit a user who does not have an email via the admin or via the user's profile (RocketChat#21626) * [IMPROVE] Inconsistent and misleading 2FA settings (RocketChat#22042) Co-authored-by: Diego Sampaio <chinello@gmail.com> * [FIX] Emails being sent with HTML entities getting escaped multiple times (RocketChat#21994) * [NEW] Remove exif metadata from uploaded files (RocketChat#22044) * [FIX] Creating roles with same name (RocketChat#21905) * [IMPROVE] CAS popup login size input type (RocketChat#21907) * [IMPROVE] LDAP port setting input type to allow only numbers (RocketChat#21912) * [FIX] Prevent the userInfo tab to return 'User not found' each time if a certain member of a DM group has been deleted (RocketChat#21970) * Remove non-used import * [FIX] Replace `query` param by `name`, `username` and `status` on the `teams.members` endpoint (RocketChat#21539) Co-authored-by: Diego Sampaio <chinello@gmail.com> * Chore: update fuselage && icons (RocketChat#22092) * [FIX] Open a new DM throwing error 404 (RocketChat#22100) * [FIX] Files list will not show deleted files. (RocketChat#21732) Co-authored-by: Douglas Fabris <deefabris@gmail.com> * Regression: Improve migration 225 (RocketChat#22099) * Remove memory leak from userData (RocketChat#22094) Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz> * [IMPROVE] Missing modal on deleting a role (RocketChat#22020) * [FIX] Fixing Jitsi call ended Issue. (RocketChat#21808) Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz> * [FIX] App license error detail message removed (RocketChat#22091) Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz> * [FIX] Directory Table's Sort Function (RocketChat#21921) Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com> Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat> * [IMPROVE] Add team members to channel when set as auto join (RocketChat#22056) Co-authored-by: Diego Sampaio <chinello@gmail.com> * Chore: Bump message parser (RocketChat#22101) * Bump version to 3.15.0-rc.0 * Fix duplicated i18n key in pt-BR file * Bump version to 3.15.0-rc.1 * Regression: Migration 225 setting not being fetched correctly (RocketChat#22108) * Bump version to 3.14.2 * [FIX][ENTERPRISE] Omnichannel Monitors can't forward chats to departments that they are not supervising (RocketChat#22128) Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> Co-authored-by: Diego Sampaio <chinello@gmail.com> * Regression: Make referrer header configurable (RocketChat#22126) * Regression: Add "User left team" message type (RocketChat#22109) * Add new ult (user left team) message type * Use new ult message type * Add new ujt (user joined team) messsage type * Bump version to 3.15.0-rc.2 * [FIX][ENTERPRISE] Omnichannel Monitors can't forward chats to departments that they are not supervising (RocketChat#22142) Co-authored-by: Diego Sampaio <chinello@gmail.com> Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com> Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> * Bump version to 3.14.3 * [FIX] Presence.get method (RocketChat#22129) * Regression: Visual issue on sort list item (RocketChat#22158) * Regression: discussions display on sidebar (RocketChat#22157) * Regression: Missing room scope on teams channels permission (RocketChat#22137) * Regression: not allowed to edit roles due to a new verification (RocketChat#22159) * Bump version to 3.15.0-rc.3 * [FIX] Discussion names showing a random value (RocketChat#22172) * Update Apps-Engine version (RocketChat#22176) * [FIX] Not possible accept video call if "Hide right sidebar with click" is enabled (RocketChat#22175) * [FIX] Discussion names showing a random value (RocketChat#22172) * Bump version to 3.14.4 * Bump: Fuselage 0.26.0 (RocketChat#22178) * Regression: Add i18n to license error messages (RocketChat#22171) * Bump version to 3.15.0-rc.4 * Bump version to 3.15.0 * DEV-4996 (#31) * Initial Launch of Rocket.Chat for Web CRM (#6) * [FIX] Updating an app via "Update" button errors out with "App already exists" (RocketChat#15814) * [FIX] Markdown link parser (RocketChat#15794) * Bump version to 2.2.1 * Allow inviting users to private channels * Update Dockerfile; Add build-container.sh * jenkins * typo * sub folder * try this * or this * docker file move * Update build-container script * Update build-container script to use random-name temp folder * Update build-container - add 'npm install' command * Change docker image name * Update Dockerfile * Remove My Accout & Logout from menu (#2) * Route to private channel instead of home page (#3) * DEV-4921 Remove /me and /create commands (#4) * DEV-4918 Remove moderation features (#5) * fix Dockerfile * move Dockerfile to the original location * DEV-4914 DEV-4915 Allow channels with the same name and public channels (#7) * Allow channels with the same name; allow creation of public channels * DEV-4840 Restrict access to user info and conversation between store groups (#8) * DEV-4846 Prevent starting a conversation with users in other store groups (#9) * DEV-4917 Redirect to store group channel if a user is removed from their current channel (#10) * DEV-4834 Add Giphy Integration (#11) * DEV-4826 add `stream-notify-admin` stream with `subscribtions-changed` event (#12) * DEV-4826 fix unread messages counting algorithm (#13) * Disable 'Invalid user' message at login * Fix error "Meteor.userId can only be invoked in method calls or publications" * DEV-8112 Hide some info in User Info panel (#14) * DEV-8195 Remove 'Get Link' button (#15) * DEV-8116 Re-skin Rocket.Cat (#16) * DEV-8116 Re-skin Rocket.Cat * DEV-8116 fix typo Co-authored-by: Sergey Volkov <sergey.volkov@coverwallet.com> * DEV-8281 Chat window fails to load (#17) * DEV-8113 add options to hide CreatedAt and LastLogin fields; update build script (#18) * DEV 8121 Hide UserName from Chat in all places (#19) * DEV-8196 Remove the ability to hide rooms (#20) * DEV-8196 Remove the ability to hide rooms * DEV-8196 Remove the ability to hide rooms - API changes * DEV-8116 fix user avatar (#21) * DEV-8235 Add store identifiers to edited channel names (#23) * DEV-8307 'Invalid User' error when chat loads (#22) * DEV-8194 Update all mentions of Chat to Chit-Chat (#24) * DEV-8306 Users redirected to 'Home' channel arbitrarily (#26) * DEV-8308 Remove 'Announcements' functionality (#27) * Add giphy package * Rename giphy folder * DEV-8624 Badge counts not showing on login or page refresh (web) (#29) * DEV-8481 Remove "rocketchat" from DOM (#28) * DEV-8253 Update Directory & Mentions to include additional user info (#25) Co-authored-by: Douglas Gubert <d-gubert@users.noreply.github.com> Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> Co-authored-by: Diego Sampaio <chinello@gmail.com> Co-authored-by: Sergey Volkov <sergey.volkov@coverwallet.com> Co-authored-by: Matt LaPaglia <mlapaglia@gmail.com> * DEV-8624 Badge counts not showing on login or page refresh (#30) * lint fixes Co-authored-by: Sergey Volkov <5180915+Sergey-Volkov@users.noreply.github.com> Co-authored-by: Douglas Gubert <d-gubert@users.noreply.github.com> Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> Co-authored-by: Diego Sampaio <chinello@gmail.com> Co-authored-by: Sergey Volkov <sergey.volkov@coverwallet.com> * DEV-8796 Remove slash commands (#34) Co-authored-by: Sergey Volkov <sergey.volkov@coverwallet.com> * DEV-8795 Programatically fix the #general channel issue (#32) * DEV-9074 Enable Private Groups and Channels to include 'All Messages' in unread counter (#35) * DEV-9074 Enable Private Groups and Channels to include 'All Message' in unread counter * Change gitversion docker image * Added header for unread section Co-authored-by: Sergey Volkov <sergey.volkov@coverwallet.com> Co-authored-by: James Loftis <james@drivecentric.com> Co-authored-by: igor <igor.rodionov@itechart-group.com> * DVOP-824: Fixed Jenkinsfile to build docker containers like atlas services (#38) * CORE-7 When chat opens initialize at most recently viewed room * New image for gitversion * change branch to main for now * test changed build * change quote type * changed syntax * test allow superuser * use tagName * Final state * add gitversion config Co-authored-by: Sergey Volkov <sergey.volkov@coverwallet.com> Co-authored-by: Sergey Volkov <sergey.volkov@itechart-group.com> * CORE-246 fix merge issues * CORE-246 rename bot user from rocket.cat to genius * npm install * temp changes: check meteor version * revert temp changes * CORE-299 Remove sendEmailAttachment slash command * CORE-299 Remove 'Home' buttons (DEV-8195) * CORE-299 Remove My Account & Logout from menu (DEV-4833) * CORE-299 Update giphy package (DEV-4834) * CORE-299 fix linting issues * disable redundant jobs * CORE-299 fix tests * CORE-246 fix DEV-8113 add options to hide CreatedAt and LastLogin fields * CORE-246 fix iframe login method * CORE-246 hide username in the Directory (DEV-8121) * CORE-246 Hide username from the room header (DEV-8121) * CORE-246 restore 'notifications-changed' stream (DEV-4826) * CORE-246 Remove the ability to hide rooms (DEV-8196) * CORE-246 fix import directive * CORE-246 disable building micro services step * CORE-246 Update Directory & Mentions to include additional user info (DEV-8253) * CORE-246 fix the issue with the direct messages * CORE-246 fix users filter * CORE-246 fix DEV-4917, CORE-10 * CORE-246 fix createDirectRoom & createWithRoomAndUser methods * CORE-246 add groupId column * CORE-246 add groupId field in admin/users table * CORE-246 fix notification stream name * CORE-246 restore 'All Messages' notification option * CORE-469 Update the subscriptions filtration logic to work with new database schema (#44) Co-authored-by: Sergey Volkov <sergey.volkov@coverwallet.com> * CORE-501 Clicking dialog with Administrator throws user out of chit-chat (#45) Co-authored-by: Sergey Volkov <sergey.volkov@coverwallet.com> * CORE-510 New Direct is not opened right after creation (#46) Co-authored-by: Sergey Volkov <sergey.volkov@coverwallet.com> * CORE-513 Left Bar UI: Options icon doesn't disappear after clicking on option (#47) Co-authored-by: Sergey Volkov <sergey.volkov@coverwallet.com> * CORE-535 Invite Link should not be displayed for users without permission (#48) Co-authored-by: Sergey Volkov <sergey.volkov@coverwallet.com> * CORE-544 'Jumped to' message being not highlighted (#49) Co-authored-by: Sergey Volkov <sergey.volkov@coverwallet.com> * CORE-543 Set/Remove as Owner update is not reflected immediately (#50) * CORE-543 Set/Remove as Owner update is not reflected immediately * CORE-543 Fixed an issue with Remove as Owner for himself * CORE-534 Remove from room button is displayed if user is not owner anymore * CORE-543 Potential fix for the issue with the isOwner property * CORE-543 fix an isse with the changeOwner method Co-authored-by: Sergey Volkov <sergey.volkov@coverwallet.com> * CORE-575 Chit-Chat: Invalid User error is encountered on login (#51) * CORE-575 Chit-Chat: Invalid User error is encountered on login * CORE-575 Disable showing error-invalid-user Co-authored-by: Sergey Volkov <sergey.volkov@coverwallet.com> * CORE-576 Room options become unavailable under certain conditions (#52) * CORE-472 CORE-576 Room options become unavailable under certain conditions * CORE-576 fix lint issue; revert redundant changes * CORE-576 Fix issue with the new DM Co-authored-by: Sergey Volkov <sergey.volkov@coverwallet.com> * CORE-619 No action happens on clicking See Full Profile link (#54) Co-authored-by: Sergey Volkov <sergey.volkov@coverwallet.com> Co-authored-by: Diego Sampaio <chinello@gmail.com> Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com> Co-authored-by: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat> Co-authored-by: Rodrigo Nascimento <rodrigoknascimento@gmail.com> Co-authored-by: Kartik Gupta <gupta.kartik18kg@gmail.com> Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz> Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat> Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com> Co-authored-by: pierre-lehnen-rc <55164754+pierre-lehnen-rc@users.noreply.github.com> Co-authored-by: Kevin Aleman <kevin.aleman@rocket.chat> Co-authored-by: Gabriel Thomé <38537062+g-thome@users.noreply.github.com> Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> Co-authored-by: Douglas Gubert <d-gubert@users.noreply.github.com> Co-authored-by: Douglas Fabris <deefabris@gmail.com> Co-authored-by: Jean <45966964+Jeanstaquet@users.noreply.github.com> Co-authored-by: lingohub[bot] <69908207+lingohub[bot]@users.noreply.github.com> Co-authored-by: Robot LingoHub <robot@lingohub.com> Co-authored-by: Thassio Victor <tvmcarvalho@gmail.com> Co-authored-by: Douglas Gubert <douglas.gubert@gmail.com> Co-authored-by: Umakant Vashishtha <41837826+umakantv@users.noreply.github.com> Co-authored-by: siva <63258524+siva2204@users.noreply.github.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lucas Sartor Chauvin <lucassartorchauvin@gmail.com> Co-authored-by: Rafael Ferreira <rafaelblink@gmail.com> Co-authored-by: Aaron Ogle <geekgonecrazy@users.noreply.github.com> Co-authored-by: Marcelo Schmidt <marcelo.schmidt@rocket.chat> Co-authored-by: Matheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com> Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat> Co-authored-by: yash-rajpal <58601732+yash-rajpal@users.noreply.github.com> Co-authored-by: Sumukha Hegde <SUMUKHA214@GMAIL.COM> Co-authored-by: Gabriel Henriques <gabriel.henriques@rocket.chat> Co-authored-by: Eduardo Pícolo <49292747+EduardoPicolo@users.noreply.github.com> Co-authored-by: savish28 <32800267+savish28@users.noreply.github.com> Co-authored-by: Darshil Patel <55157259+Darshilp326@users.noreply.github.com> Co-authored-by: Avi Press <avipress@gmail.com> Co-authored-by: Renan Cleyson <renancleyson.f@gmail.com> Co-authored-by: Bhavay Anand <bhavayanandcse@gmail.com> Co-authored-by: Shrinish Vhanbatte <56491104+shrinish123@users.noreply.github.com> Co-authored-by: Deepak Agarwal <deepak710agarwal@gmail.com> Co-authored-by: Matt LaPaglia <mlapaglia@gmail.com> Co-authored-by: Sergey Volkov <sergey.volkov@coverwallet.com> Co-authored-by: James Loftis <james@drivecentric.com> Co-authored-by: igor <igor.rodionov@itechart-group.com> Co-authored-by: Jamie <41797578+JamieDriveCentric@users.noreply.github.com>
Proposed changes (including videos or screenshots)
When you are in the admin and want to change a room 'd' setting, it doesn't work because it takes into account the name that is set automatically and therefore tries to save that name. Since the name is not valid and should not be registered, we cannot change the setting for the 'd' room.
I made sure that when you want to change a setting in a 'd' room, that you don't take the name into account
2021-04-18.17-10-16.mp4
Behind the scene, the name is not saved
Issue(s)
Fixes #21635
Steps to test or reproduce
Further comments